Remove Pantry pod

[Abizern]

Depends on #179.

The project uses Pantry for deserialisations and storage. As noted in Pantry's README, it is no longer going to be supported.

So we should probably refactor to use the Codable protocol available in Swift 4. Not a small job.

[nickoneill]

Sorry :(

[subdigital]

You can blame me for trusting you. I TRUSTED YOU!

;)

[mccarron]

We all believed in youuuuuuu

…

On Oct 7, 2017, at 11:30 AM, Ben Scheirman ***@***.***> wrote: You can blame me for trusting you. I TRUSTED YOU! ;) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Abizern]

If I say "How about decodable for de-serialisation and Core Data for persistence"? will I be chased out of town with pitchforks?

[subdigital]

Why not codable for both? Works really well 😎

…

Sent from my iPhone

On Oct 10, 2017, at 6:42 PM, Abizer Nasir ***@***.***> wrote: If I say "How about decodable for de-serialisation and Core Data for persistence"? will I be chased out of town with pitchforks? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[nickoneill]

I'm a believer in decodable for it's simplicity, obviously.

FYI, I expect the user stats will be stored on the server sooner rather than later. So will eventually be a lot less data we're actually keeping track of here.

[nickoneill]

Not sure if we want to be ambitious enough to get this in the next release. Please advise.

[Abizern]

I don’t think so. I need to finish the font stuff first. Also, I don’t want to rush the migration testing for whatever we do, so let’s stick with Pantry for now. It works. It’s just that it’s not supported going forwards. If things get really messed up I’m sure we can get the owner to do something.

…

On 15 Oct 2017, at 22:18, nickoneill ***@***.***> wrote: Not sure if we want to be ambitious enough to get this in the next release. Please advise. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#182 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAa9iR12L3J1Dx4V9umOG1_LLWhWj1Nks5ssnaTgaJpZM4PxU6e>.

[nickoneill]

Yeah, that jerk.

[Abizern]

Also - re cloud sync. Won't that require some kind of log in? An extra hurdle. An extra bit of inertia. I was thinking, maybe CloudKit so that stats are kept between iPhone and iPad apps for the single user. We could even do a macOS app (it's been a while since I've done them and it would be a good excuse for me to get back into it).

Just something to think about and we can discuss it somewhere else.

[Abizern]

This pod doesn't work with Swift 5, but we knew that would happen.

The only thing that seems to use pantry is ContactLogs, so the impact is fairly contained.

I'll assign it to myself, unless somebody else wants to take a look at it.

[Abizern]

Could somebody add (or send me) the contents of the "com.thatthinginswift.pantry" directory in documents (app or simulator) so that I have something to test against?

Thank you.

[nickoneill]

This is being handled in #261 as well

[nickoneill]

Fixed in #261

[Abizern]

This is still used for ContactLogs.

I'm happy to take a look at it of somebody can send me a copy of the contents of "com.thatthinginswift.pantry" directory (device or simulator) so that I can test a migration.

[nickoneill]

😬 That's unfortunate, will send you an example directory today.

[Abizern]

Hey, it happens. 😁

[nickoneill]

I'm not sure how best to ship you an example directory for the pantry data. If you click through a couple calls with "unavailable" (anything other than skip really), you should be able to generate some standard test data. These won't be submitted in debug mode, so don't worry about that.

[Abizern]

Okay. I'll try that. When it's done I'd appreciate some testing to make sure that the migrations are handled properly on an actual device.

As an aside, is it possible to add my developer developer account to the 5calls development certificate so that I can run the test builds on my devices (abizern (at) mac dot com). If so, who should I ask?

[nickoneill]

Yep, I'll find a few devices with good call histories on them for testing.

Sent you an invite to the team, make yourself a dev certificate as you see fit!

[Abizern]

Thanks very much!

[nickoneill]

Any luck on this @Abizern? I may try to hack on this if you haven't had the chance to start yet

[Abizern]

I’ve put some thought into it. Got distracted last week. I’ll still get it done, provisional PR this week if that’s okay for your time frame?

…

-- Abizer

On 16 Jun 2019, at 22:18, nickoneill ***@***.***> wrote: Any luck on this @Abizern? I may try to hack on this if you haven't had the chance to start yet — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[nickoneill]

That's good for me, just checking that it's still moving forward 👍