Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic height rows seems to cause the issues list to shuffle #23

Closed
subdigital opened this issue Feb 4, 2017 · 3 comments
Closed

Dynamic height rows seems to cause the issues list to shuffle #23

subdigital opened this issue Feb 4, 2017 · 3 comments

Comments

@subdigital
Copy link
Collaborator

I noticed that once we supported dynamic height on the issues list, the table reshuffles strangely when scrolling.

Another (probably related) thing is this occasionally causes our labels to no longer wrap & cause their cell to increase in height, instead reverting to truncating with ellipses ('...').

@subdigital
Copy link
Collaborator Author

@bjtitus is looking into this

@mccarron
Copy link
Collaborator

mccarron commented Feb 5, 2017

Likely what I see doing this as well

simulator screen shot feb 4 2017 7 57 21 pm

bjtitus added a commit to bjtitus/ios that referenced this issue Feb 5, 2017
@bjtitus
Copy link
Contributor

bjtitus commented Feb 5, 2017

@mccarron @subdigital See if that PR fixes your issue. The unnecessary reload call is what was triggering this for me. Let me know if you're seeing it in other cases with that call removed.

subdigital added a commit that referenced this issue Feb 5, 2017
Remove cell reload on viewWillAppear. Fixes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants