#59 Fixed the image flashing in the IssueDetailViewController avatars
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbrandow
changed the title
IssueDetailViewController avatarsIssueDetailViewController avatars
|
This solves the issue on So maybe we should instead of AppDelegate or a Singleton just use |
|
Definitely would prefer using |
* `[String: UIImage]` property to `IssueDetailViewController`
* check it when setting `cell.avatarImageView.image`
* or set it after downloading remote image
* added `setRemoteImage` method with a "preferredImage" argument
This solution is memory only, and is local to this `IssueDetailViewController`, but could be moved to a singleton/app delegate.
or we could use an existing cache solution. Seems like a small thing to pull in another dependency for.
subdigital
force-pushed
the
flashingImages
branch
from
f827104
to
e9583fc
Compare
|
@chrisbrandow thanks for starting this off! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59
This solution is memory only, and is local to this
IssueDetailViewController, but could be moved to a singleton/app delegate.Or, conversely, we could use an existing cache solution. However, this seems like a small thing to pull in another dependency for.
[String: UIImage]property toIssueDetailViewControllercell.avatarImageView.imagesetRemoteImagemethod with a "preferredImage" argument