Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource://dactyl-content/bookmarks.js: 376: TypeError: window.convertFromUnicode is not a function #201

Closed
sanjayankur31 opened this issue Feb 2, 2017 · 3 comments

Comments

@sanjayankur31
Copy link

Hiya,

I get this error when I add new keyword searchs and attempt to use them via pentadactyl:

resource://dactyl-content/bookmarks.js: 376: TypeError: window.convertFromUnicode is not a function

I've tested it with a new keyword search for GitHub and Google Scholar, and I get the same error both times.

How to reproduce:

  • Go to Github
  • Right click on top search box
  • Click "Add keyword for this search"
  • Add a keyword, for example, github-search
  • Once added, press t (for new tab)
  • Type in github-search followed by a search term

It errors. Same process with Google-Scholar too.

I'm not sure if this is a dactyl or a FF error. i've only noticed it breaking recently. I see quite a few posts regarding errors with keyword search, so it could be an FF error.

@sanjayankur31
Copy link
Author

A workaround seems to be to manually edit the search link and remove stuff other than the q=%s part. So, the github search URL becomes: https://github.com/search?q=%s, for example.

@timacs
Copy link

timacs commented Feb 2, 2017

I also start getting this error with keyword searches after upgrading FF from 50 to 51.

@mgollo
Copy link

mgollo commented Feb 13, 2017

I can confirm tim-teufel's comment: I get this for all searches since the upgrade to FF51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants