Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined damage types #83

Closed
bagelbits opened this issue Sep 5, 2019 · 1 comment
Closed

Combined damage types #83

bagelbits opened this issue Sep 5, 2019 · 1 comment
Assignees

Comments

@bagelbits
Copy link
Collaborator

bagelbits commented Sep 5, 2019

While reviewing a PR I noticed for some of the monsters we show damage dice and damage bonus but we don't differentiate between what kinds of damage each roll is. It might not be a bad idea to determine a better way to convey damage. I'll probably think on this some when I have some time but I'll happily review a PR if anyone wants to take a crack at it.

@bagelbits
Copy link
Collaborator Author

Probably something like this:

[
  {
    "damage_dice": "4d4",
    "damage_bonus": "4",
    "damage_type": "thunder"
  },
  {
    "damage_dice": "4d4",
    "damage_bonus": "0",
    "damage_type": "holy"
  }
]

@bagelbits bagelbits mentioned this issue Sep 26, 2019
7 tasks
@bagelbits bagelbits self-assigned this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant