Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race Traits contain incorrect URL #99

Closed
cjo1pal opened this issue Oct 11, 2019 · 3 comments
Closed

Race Traits contain incorrect URL #99

cjo1pal opened this issue Oct 11, 2019 · 3 comments

Comments

@cjo1pal
Copy link
Contributor

cjo1pal commented Oct 11, 2019

5e-SRD-Races.json
Some of the Racial Traits for the different races have the incorrect url associated with the name in the Traits section.

EX:
Elf Traits
traits": [ { "url": "http://www.dnd5eapi.co/api/traits/5", "name": "Darkvision (Elf)"
Darkvision is http://www.dnd5eapi.co/api/traits/1
@cjo1pal cjo1pal changed the title Race Traits incorrect ulr Race Traits contain incorrect URL Oct 11, 2019
@bagelbits
Copy link
Collaborator

Nice catch. I don't know when I'll have a chance to fix this and review all of the traits but if you want to open a PR for the fixes, I'm happy to review it.

@cjo1pal cjo1pal mentioned this issue Oct 15, 2019
Merged
@cjo1pal
Copy link
Contributor Author

cjo1pal commented Oct 15, 2019

@bagelbits I just created that pull request for this issue.
Now that I know how to do this I'll submit more as I find issues with the files.

bagelbits pushed a commit that referenced this issue Oct 16, 2019
@cjo1pal @bagelbits
Pull Request for Issue #99 (#100)
198ad72 
* Updated Races traits urls accodring to the Traits page urls

* Updated Races traits urls according to the Traits page urls. Also deleted Darkvision Class specifiers.
@bagelbits
Copy link
Collaborator

Thank you for doing this! And appreciate you creating additional PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bagelbits @cjo1pal