feat: Add size and shape to dragonborn's breath weapon #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagelbits
reviewed
Aug 8, 2022
src/5e-SRD-Traits.json
Outdated
| @@ -759,6 +759,7 @@ | |||
| "breath_weapon": { | |||
| "name": "Breath Weapon", | |||
| "desc": "You can use your action to exhale destructive energy. Your draconic ancestry determines the size, shape, and damage type of the exhalation. When you use your breath weapon, each creature in the area of the exhalation must make a saving throw, the type of which is determined by your draconic ancestry. The DC for this saving throw equals 8 + your Constitution modifier + your proficiency bonus. A creature takes 2d6 damage on a failed save, and half as much damage on a successful one. The damage increases to 3d6 at 6th level, 4d6 at 11th level, and 5d6 at 16th level. After you use your breath weapon, you can't use it again until you complete a short or long rest.", | |||
| "size_and_shape": "5 by 30 ft. line", | |||
There was a problem hiding this comment.
Would it make sense to split this up more? Since we can standardize shape and use it in other places (like spells). And we can probably standardize size too.
There was a problem hiding this comment.
Something like:
{
size: string;
shape: string;
}
?
There was a problem hiding this comment.
Actually, I think Spells already have an area_of_effect field. It would probably make more sense to use that and potentially expand on it? Just for consistency. I can also see this being used for some monster attacks.
There was a problem hiding this comment.
bagelbits
approved these changes
Aug 10, 2022
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
bagelbits
pushed a commit
that referenced
this pull request
Aug 10, 2022
* feat: Add size and shape to dragonborn's breath weapon * Use area od effect object instead of size and shape string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds size and shape of dragonborn's breath weapon since the API didn't have that information already
How was it tested?
I ran
db:refreshand looked at the data with mongo db compass.Is there a Github issue this is resolving?
n/a
Did you update the docs in the API? Please link an associated PR if applicable.
Yes.
Here's a fun image for your troubles