Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Monster Armor Types #518

Merged
merged 10 commits into from Jan 30, 2023
Merged

feat: Add Monster Armor Types #518

merged 10 commits into from Jan 30, 2023

Conversation

bagelbits
Copy link
Collaborator

@bagelbits bagelbits commented Dec 13, 2022

BREAKING CHANGE: Changes the shape of armor_class in monsters

What does this do?

Changes the shape of armor_class in monsters from a number to:

type ArmorClass = (ArmorClassDex | ArmorClassNatural | ArmorClassArmor | ArmorClassSpell | ArmorClassCondition)[];
type ArmorClassDex = {
  type: "dex";
  value: number;
  desc?: string;
};
type ArmorClassNatural = {
  type: "natural";
  value: number;
  desc?: string;
}
type ArmorClassArmor = {
  type: "armor";
  value: number;
  armor?: APIReference[]; // Equipment
  desc?: string;
}
type ArmorClassSpell = {
  type: "spell";
  value: number;
  spell: APIReference; // Spell
  desc?: string;
}
type ArmorClassCondition = {
  type: "condition";
  value: number;
  condition: APIReference; // Condition
  desc?: string;
}

How was it tested?

CI

Is there a Github issue this is resolving?

#280

Did you update the docs in the API? Please link an associated PR if applicable.

Yes

Here's a fun image for your troubles

image

@bagelbits bagelbits changed the title feat: Comprehensive feat: Add Monster Armor Types Dec 13, 2022
@bagelbits bagelbits marked this pull request as draft December 13, 2022 20:01
@bagelbits bagelbits merged commit b7bf853 into main Jan 30, 2023
@bagelbits bagelbits deleted the bagelbits.monster-ac branch January 30, 2023 21:12
@github-actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant