This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ebastianMeier
approved these changes
Oct 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gute Arbeit! Bei einigen Dingen sind die Typen noch nicht so präzise (bspw. Configs, Callbacks, etc.). Das kann ich mir aber separat nochmal anschauen.
Naja typisiert war das ganze ja ohnehin bisher nur sehr ... dünn. ^^ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PR: #35
How can others test the changes?
Build some typescript code with this new module.
PR-Checklist
Please check the boxes in this list after submitting your PR:
develop
branch with my branch before finishing this PR.Example
Please use
:twisted_rightwards_arrows:
at the beginning of your merge commit title.Example 1:
To get your commit message, just copy the first part of this pull request.
Example 2:
Emojis
Expand for a list of most used Emojis.
Please prefix your commit messages with an Emoji.
Ref: https://gitmoji.carloscuesta.me/
:bug:
:wrench:
:lipstick:
:arrow_down:
:arrow_up:
:art:
:zap:
:tada:
:rotating_light:
:package:
:sparkles:
:recycle:
:bookmark:
:fire:
:white_check_mark:
:construction: