Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

⬆️ Upgrade to gulp v4 #35

Merged
merged 17 commits into from
Oct 31, 2018
Merged

⬆️ Upgrade to gulp v4 #35

merged 17 commits into from
Oct 31, 2018

Conversation

ElRaptorus
Copy link
Member

Changes:

  1. Upgrade dependencies to fix vulnerability issues
    • Remove lodash
  2. Finish implementing the gulp v4 adapter
  3. Various stylefixes
  4. Update the transpilations

PR: #35

How can others test the changes?

Build some typescript code with this new module.

PR-Checklist

Please check the boxes in this list after submitting your PR:

  • You can merge this PR right now (if not, please prefix the title with "WIP: ")
  • I've tested all changes included in this PR.
  • I've also reviewed this PR myself before submitting (e.g. for scrambled letters, typos, etc.).
  • I've rebased the develop branch with my branch before finishing this PR.
  • I've summarized all changes in a list above.
  • I've mentioned all PRs, which relate to this one.
  • I've prefixed my Pull Request title is according to gitmoji guide.

Example

⚠️ Before merging please click here to expand and follow the guide.

Please use :twisted_rightwards_arrows: at the beginning of your merge commit title.

Example 1:


:twisted_rightwards_arrows: :bug: Fix Wrong Text Decoration at ...

To get your commit message, just copy the first part of this pull request.

Example 2:


**Changes:**

- Fixes Wrong Text Decoration at ...
- Fixes some typos
- ...

**Issues:**

Closes #NumberOfFixedIssue

PR: #NumberOfThisPR

Emojis

Expand for a list of most used Emojis.

Please prefix your commit messages with an Emoji.

Ref: https://gitmoji.carloscuesta.me/

Description Glyphe Emoji
Bugfix :bug: 🐛
Configuration releated :wrench: 🔧
Cosmetic :lipstick: 💄
Dependencies Downgrade :arrow_down: ⬇️
Dependencies Upgrade :arrow_up: ⬆️
Formatting :art: 🎨
Improving Performance :zap: ⚡️
Initial commit :tada: 🎉
Linter :rotating_light: 🚨
Miscellaneous :package: 📦
New Feature :sparkles:
Refactoring Code :recycle: ♻️
Releasing / Version tags :bookmark: 🔖
Removing Stuff :fire: 🔥
Tests :white_check_mark:
Work In Progress (WIP) :construction: 🚧

Copy link

@5ebastianMeier 5ebastianMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gute Arbeit! Bei einigen Dingen sind die Typen noch nicht so präzise (bspw. Configs, Callbacks, etc.). Das kann ich mir aber separat nochmal anschauen.

@ElRaptorus
Copy link
Member Author

Naja typisiert war das ganze ja ohnehin bisher nur sehr ... dünn. ^^

@ElRaptorus ElRaptorus merged commit 8803e93 into develop Oct 31, 2018
@ElRaptorus ElRaptorus deleted the feature/upgrade_gulp branch October 31, 2018 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants