Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements change detection fails for -r sub.pip #2

Closed
lericson opened this issue Dec 23, 2014 · 3 comments
Closed

Requirements change detection fails for -r sub.pip #2

lericson opened this issue Dec 23, 2014 · 3 comments

Comments

@lericson
Copy link
Contributor

If a requirements file includes another requirements file, the app.deploy task won't figure that out. It would have to actually parse the contents to know.

@joar
Copy link
Contributor

joar commented Apr 28, 2015

you can work around this by using a separate, standalone, file for each environmentt and point out the file to use with

settings:
  app:
    requirements: requirements-live.txt  
    # paths ending with .pip or .txt ar passed to 'pip install -r', 
    # paths ending with .py are passed to 'pyhon {} develop'.format(name)

@lundberg
Copy link
Contributor

Could be done by recursive parse, but should probably be too slow since each file would needed to be fetched from server for comparison. One could instead change the -r usage the other way around, like using a master requirements file for live environment in repo root and then for dev/staging use a separate with debug-addons and a reference to the master.

@joar
Copy link
Contributor

joar commented May 25, 2015

I have some progress on this in a local tree, now pushed to feature branch:
https://github.com/5monkeys/blues/tree/feature/parse-requirements

On Mon, May 25, 2015 at 9:14 AM, Jonas Lundberg notifications@github.com
wrote:

Could be done by recursive parse, but should probably be too slow since
each file would needed to be fetched from server for comparison. One could
instead change the -r usage the other way around, like using a master
requirements file for live environment in repo root and then for
dev/staging use a separate with debug-addons and a reference to the master.


Reply to this email directly or view it on GitHub
#2 (comment).

Joar Wandborg
wandborg.se

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants