Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nested menu items #28

Merged
merged 14 commits into from
Nov 26, 2019
Merged

Feature/nested menu items #28

merged 14 commits into from
Nov 26, 2019

Conversation

skrhlm
Copy link
Contributor

@skrhlm skrhlm commented Nov 11, 2019 •
edited

  • Add the (backwards-compatible) feature of nestling navigation items.
  • Add the option to pass in an array of props for the NavItems via the nav prop in Bananas.Admin component.
  • Turn Navigation into a functional component.

TODO:

  • Fix highlighting of parent when a child that does not share the same base path is selected.
  • Fix / Add tests
  • Document added features

@skrhlm skrhlm added the WIP Work in progress label Nov 11, 2019
@skrhlm skrhlm removed the WIP Work in progress label Nov 19, 2019
@skrhlm skrhlm merged commit 327f3e9 into master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@skrhlm