New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BigAutoField #120
Merged
Merged
Use BigAutoField #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jocke-l
force-pushed
the
big-auto-field
branch
from
October 11, 2023 10:37
722853e
to
9351de0
Compare
flaeppe
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets run 3.11 since 3.12 doesn't run in CI
Co-authored-by: Petter Friberg <petter@5monkeys.se>
Co-authored-by: Petter Friberg <petter@5monkeys.se>
Co-authored-by: Petter Friberg <petter@5monkeys.se>
Co-authored-by: Petter Friberg <petter@5monkeys.se>
Co-authored-by: Petter Friberg <petter@5monkeys.se>
jocke-l
changed the title
Use BigAutoField for djedi.backends.django.db.models.Node
Use BigAutoField
Oct 11, 2023
flaeppe
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Django 3.2
DEFAULT_AUTO_FIELD
is automatically set toBigAutoField
for new projects. Let's have this as default for Djedi as well.https://docs.djangoproject.com/en/3.2/releases/3.2/#customizing-type-of-auto-created-primary-keys