Ensure no duplicated AST nodes are produced #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydell
approved these changes
Sep 1, 2019
| @@ -66,6 +75,18 @@ _djedi.reportPrefetchableNode({ | |||
| `); | |||
| }); | |||
|
|
|||
| test("ensure no duplicated AST nodes are found", () => { | |||
There was a problem hiding this comment.
Nice! Didn’t know about babel-check-duplicated-nodes before.
|
Yaeh, super weird! A friend of mine used this library in her project and stumbled upon this issue when trying to get SSR to work. Although SSR has never triggered this issue in our projects, I was able to reproduce it by running Merging this in then! Thanks for taking a look at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our babel plugin produced an invalid AST which caused some inconsistencies in some projects, where babel would generate invalid JS code. The reason for that was that we have reused some AST nodes without cloning them. More background here.
Solves #57.