Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python/docker, switch to Github Actions #89

Closed
wants to merge 35 commits into from
Closed

Conversation

Mojken
Copy link
Contributor

@Mojken Mojken commented Mar 24, 2022

No description provided.

tox.ini Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 24, 2022

File Coverage Missing
All files 89%
__init__.py 85% 22-23
compat.py 66% 12 18 25-26 28-29 35 59-60 73 77 86
models.py 75%
urls.py 67% 8
admin/api.py 96% 220
admin/cms.py 77% 23 26 29 34 44
admin/mixins.py 91%
auth/__init__.py 90% 26
backends/django/db/backend.py 92%
middleware/__init__.py 80% 17-19
middleware/mixins.py 81% 30-31 42-43 57-58 63-64 101
plugins/base.py 87% 9
plugins/form.py 91% 17-18 46
plugins/img.py 91% 74 105-106 115-116
templatetags/template.py 94% 48
tests/base.py 78% 18 91-92 94-95 97-98 102
tests/compat.py 62% 8-9 13
tests/test_admin.py 64% 43-53
tests/test_rest.py 95% 24
tests/urls.py 81% 10
utils/encoding.py 65% 4
utils/templates.py 93% 21-22

Minimum allowed coverage is 93%

Generated by 🐒 cobertura-action against 7e86f93

Copy link
Contributor

@Swamii Swamii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost 😄

.github/workflows/main.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Mojken Mojken force-pushed the feature/ci branch 5 times, most recently from 53dce4f to b4eb3c8 Compare March 28, 2022 13:17
@Mojken Mojken enabled auto-merge (squash) March 28, 2022 13:29
@Mojken Mojken force-pushed the feature/ci branch 3 times, most recently from 03cc539 to 5dd8410 Compare March 29, 2022 06:16
@Mojken Mojken disabled auto-merge March 29, 2022 08:29
Copy link
Contributor

@Swamii Swamii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

setup.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
Copy link
Contributor

@lundberg lundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few "no-op" functions left ... let's remove them to get rid of unnecessary compat-stuff.

Might have missed some (?)

djedi/tests/compat.py Outdated Show resolved Hide resolved
djedi/tests/compat.py Outdated Show resolved Hide resolved
djedi/tests/urls.py Outdated Show resolved Hide resolved
djedi/utils/encoding.py Outdated Show resolved Hide resolved
djedi/compat.py Outdated Show resolved Hide resolved
djedi/compat.py Outdated Show resolved Hide resolved
djedi/compat.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lundberg lundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Side note...it would've been great if no formatting was done in this PR, made it a lot harder to review and ensure no logic/tests were touched 😅 .

@Mojken
Copy link
Contributor Author

Mojken commented Mar 30, 2022

I've gone ahead and merged the pre-commit PR into this (hence the complete rewrite of the history), so the files changed-count will go down drastically once that PR is merged in!

@Mojken
Copy link
Contributor Author

Mojken commented Mar 31, 2022

Closed in favor of #95

@Mojken Mojken closed this Mar 31, 2022
@Mojken Mojken deleted the feature/ci branch March 31, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants