New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python/docker, switch to Github Actions #89
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7e86f93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost 😄
53dce4f
to
b4eb3c8
Compare
03cc539
to
5dd8410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few "no-op" functions left ... let's remove them to get rid of unnecessary compat-stuff.
Might have missed some (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Side note...it would've been great if no formatting was done in this PR, made it a lot harder to review and ensure no logic/tests were touched 😅 .
--no-binary breaks some django versions because all translation files are skipped
The issue is that coverage.py doesn't support 3.6 anymore (EOL 2021-12-23), so we couldn't generate coverage reports for it.
Instead of for each matrix step
There are now no compat issues. With some work, the compat files can be removed completely
Since we don't generate the lcov report more than once now, we can support 3.6 again!
I've gone ahead and merged the pre-commit PR into this (hence the complete rewrite of the history), so the files changed-count will go down drastically once that PR is merged in! |
Closed in favor of #95 |
No description provided.