New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using webpack hmr api on server instead of webpack-hot-server-middleware #66

Closed

richardscarrott wants to merge 1 commit into master from feature/hmr-webpack-api

Member

richardscarrott commented Oct 24, 2016 •

edited

Loading

TODO:

Hook up client side assets.
Use in-memory compilation from webpack-dev-server (although actually it looks although 'webpack/hot/poll' is only capable of reading from the file system as it uses node require to fetch the hot update manifest and chunks).
Pass client stats to serverRenderer middleware.

Observations

Given this will need to require() the server bundle from the memory fs to perform the initial mount anyway it doesn't really seem worth going through the Webpack HMR api to switch the server renderer middleware to the latest compilation when it can just be switched on each compilation (i.e. exactly how webpack-hot-server-middleware does).


          Try using webpack hmr api on server instead of webpack-hot-server-mid…

81a5863

…dleware

coveralls commented Oct 24, 2016

Coverage remained the same at 98.039% when pulling 81a5863 on feature/hmr-webpack-api into 96afcf6 on master.

richardscarrott closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment