Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement ringtone #161

Closed
eofster opened this issue Dec 23, 2015 · 0 comments
Closed

Reimplement ringtone #161

eofster opened this issue Dec 23, 2015 · 0 comments
Assignees
@eofster
Labels
maintenance
Milestone
1.1.5

Comments

@eofster
Copy link
Member

eofster commented Dec 23, 2015

Ringtone is currently owned by the App Controller and used directly by other objects. Because the ringtone is part of the audio device and sound IO refactoring being done in #145 and #158, it should be changed according to the new architecture.
@eofster eofster self-assigned this Dec 23, 2015
@eofster eofster added this to the 1.1.5 milestone Dec 23, 2015
eofster added a commit that referenced this issue Jan 14, 2016
@eofster
Create ringtone-related types in use cases
4c265be 
Issue #161
eofster added a commit that referenced this issue Jan 14, 2016
@eofster
Add RingtoneInteractor
3b39d80 
Issue #161
eofster added a commit that referenced this issue Jan 15, 2016
@eofster
Add RingtoneFactoryImpl
0da3ca4 
Issue #161
eofster added a commit that referenced this issue Jan 15, 2016
@eofster
Add NSSoundToSoundAdapter
7aeac54 
Issue #161
eofster added a commit that referenced this issue Jan 15, 2016
@eofster
Add SoundFactoryImpl
7ef21c5 
Issue #161
eofster added a commit that referenced this issue Jan 15, 2016
@eofster
Add Timer and TimerFactory implementations
8687d7d 
Issue #161
eofster added a commit that referenced this issue Jan 16, 2016
@eofster
Rename RingtoneInteractor to RingtonePlaybackInteractor
3e87385 
Issue #161
eofster added a commit that referenced this issue Jan 28, 2016
@eofster
Use SoundConfiguration for ringtone creation
038ed44 
Issue #161
eofster added a commit that referenced this issue Jan 28, 2016
@eofster
Compose RingtonePlaybackInteractor
39f2daf 
Issue #161
eofster added a commit that referenced this issue Jan 28, 2016
@eofster
Add ConditionalRingtonePlaybackInteractor
0309e06 
Issue #161
eofster added a commit that referenced this issue Jan 28, 2016
@eofster
Add ConditionalRingtonePlaybackInteractorDelegate implementation
722ca3a 
Issue #161
eofster added a commit that referenced this issue Jan 28, 2016
@eofster
Compose ConditionalRingtonePlaybackInteractor
14b6649 
Issue #161
eofster added a commit that referenced this issue Jan 29, 2016
@eofster
Inject Ringtone Playback Interactor into Account Controllers
5455389 
Issue #161
eofster added a commit that referenced this issue Jan 29, 2016
@eofster
Inject Ringtone Playback Interactor into Call Controllers
ca9f1de 
Issue #161
eofster added a commit that referenced this issue Jan 30, 2016
@eofster
Add UserDefaultsRingtoneSoundNameSaveInteractor
d7deb4b 
Issue #161
eofster added a commit that referenced this issue Jan 30, 2016
@eofster
Add ringtone name change event handling
5faa570 
Issue #161
eofster added a commit that referenced this issue Jan 30, 2016
@eofster
Notify observer about ringtone name change
1af3e96 
Issue #161
eofster added a commit that referenced this issue Jan 30, 2016
@eofster
Rename interactor variable
01f00f9 
Issue #161
eofster added a commit that referenced this issue Feb 7, 2016
@eofster
Rename RingtoneFactoryImpl to UserDefaultsRingtoneFactory
9d51d2d 
Issue #161
eofster added a commit that referenced this issue Feb 7, 2016
@eofster
Rename TimerImpl to NSTimerToTimerAdapter
4c8e019 
Issue #161
eofster added a commit that referenced this issue Feb 7, 2016
@eofster
Rename TimerFactoryImpl to NSTimerToTimerAdapterFactory
9209e1e 
Issue #161
eofster added a commit that referenced this issue Feb 7, 2016
@eofster
Rename SoundFactoryImpl to UserDefaultsSoundFactory
e6379aa 
Issue #161
eofster added a commit that referenced this issue Feb 7, 2016
@eofster
Move sound configuration load to the sound factory
17cafbc 
Issue #161
eofster added a commit that referenced this issue Feb 7, 2016
@eofster
Rename UserDefaultsRingtoneFactory to RepeatingSoundFactory
13dc208 
Issue #161
eofster added a commit that referenced this issue Feb 16, 2016
@eofster
Add SoundObserver
7c711b3 
Issue #161
eofster added a commit that referenced this issue Feb 16, 2016
@eofster
Add SoundPlaybackInteractor
ddba3a4 
Issue #161
eofster added a commit that referenced this issue Mar 11, 2016
@eofster
Fix typo
509f020 
Issue #161
eofster added a commit that referenced this issue Mar 11, 2016
@eofster
Play ringtone sound after changing ringtone name
834487b 
Issue #161
eofster added a commit that referenced this issue Mar 11, 2016
@eofster
Remove old ringtone sound playback
34032ac 
Issue #161
eofster added a commit that referenced this issue Mar 11, 2016
@eofster
Stop current sound before playing the new one
90c584a 
Issue #161
eofster added a commit that referenced this issue Mar 14, 2016
@eofster
Add playing property to RingtonePlaybackInteractor
ea92e9a 
Issue #161
eofster added a commit that referenced this issue Mar 14, 2016
@eofster
Add RingtoneOutputUpdateInteractor
5cf084b 
Issue #161
eofster added a commit that referenced this issue Mar 14, 2016
@eofster
Add ringtone output update to view event target
0d013f3 
Issue #161
eofster added a commit that referenced this issue Mar 14, 2016
@eofster
Stop playing ringtone sound when view disappears
083580e 
Issue #161
eofster added a commit that referenced this issue Mar 14, 2016
@eofster
Notify view controller about view disappearance
bef49a2 
Issue #161
eofster added a commit that referenced this issue Mar 14, 2016
@eofster
Remove old audio device- and ringtone-related code
3362e18 
Issues #145 #158 #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Rename InteractorFactoryImpl to DefaultInteractorFactory
d0a3a0d 
Issues #145 #158 #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Rename RingtonePlaybackInteractor
b0f5753 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Shorter variable name
5c62aaa 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Shorter variable names in RingtonePlaybackInteractor
acc0648 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Rename timeInterval to interval
f098ab4 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Rename and extract SoundConfigurationLoadInteractor protocol
249a283 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Use injected instance
4f11e49 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Shorter variable names in UserDefaultsSoundFactory
7cdabac 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Shorter factory method name for RingtoneSoundNameSaveInteractor
42dbd55 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Shorter names in UserDefaultsRingtoneSoundConfigurationLoadInteractor
9a7496f 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Shorter names in UserDefaultsRingtoneSoundNameSaveInteractor
7b920f9 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Extract SoundPlaybackInteractor protocol
098c3a9 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Shorter names in DefaultSoundPlaybackInteractor
94c82ea 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Shorter name in RepeatingSound
7bda9ad 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Revert "Shorter factory method name for RingtoneSoundNameSaveInteractor"
c88bb21 
This reverts commit 42dbd55.

Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Extract method
f021012 
Issue #161
eofster added a commit that referenced this issue Mar 17, 2016
@eofster
Avoid dangling pointer after deallocation
5f25c4f 
Issue #161
@eofster eofster closed this as completed Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eofster eofster

Labels
maintenance
Projects
None yet
Milestone
1.1.5
Development

No branches or pull requests
1 participant
@eofster