Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button loading state #17

Merged
merged 2 commits into from May 5, 2020
Merged

button loading state #17

merged 2 commits into from May 5, 2020

Conversation

seddie62
Copy link
Contributor

@seddie62 seddie62 commented May 1, 2020

Issue => #15

@seddie62 seddie62 linked an issue May 1, 2020 that may be closed by this pull request
Support loading state on buttons #15
Closed
2 tasks
pepeloper
pepeloper reviewed May 4, 2020
View reviewed changes
src/components/R64Button.vue
@@ -185,6 +187,9 @@ export default {
transform: translateZ(0);
animation: load8 1.1s infinite linear;
}
.loader-outline {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extract this class to the button theme config. So people can override it.

@pepeloper
Copy link
Contributor

Looks good! 👍 Just few things to point out

  • Update docs
  • Add a preview on src/dev.vue component. Doing a timeout on the submit button will be a good example.

@pepeloper pepeloper merged commit 81e1b79 into master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeloper pepeloper pepeloper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support loading state on buttons
2 participants
@seddie62 @pepeloper