fix: gr_cls #2
fix: gr_cls #2
Conversation
| @@ -195,7 +195,8 @@ gr_scrngeom_hires | |||
| db gr_hires_x, 0 | |||
| db gr_hires_y, 0 | |||
|
|
|||
| ; Only need to initialise text height, width is same as before | |||
| ; Only need to initialise text height, width is same as before (iss: really? ;) | |||
There was a problem hiding this comment.
Oops yes, you are right - the width is not initialised!
| @@ -195,7 +195,8 @@ gr_scrngeom_hires | |||
| db gr_hires_x, 0 | |||
| db gr_hires_y, 0 | |||
|
|
|||
| ; Only need to initialise text height, width is same as before | |||
| ; Only need to initialise text height, width is same as before (iss: really? ;) | |||
| db gr_text_w, 40 | |||
There was a problem hiding this comment.
However a better fix is not to initialise this here with two extra bytes, but remove the '-1' that terminates the base table and I can also remove gr_mode initialisation here as it is done in gr_scrngeom_txt.
This way the init tables are a bit smaller - which may help if other bugs are found where additional bytes are going to be needed :-)
There was a problem hiding this comment.
You caught another bug - thanks! But on checking the fix, I realised the mistake is that a -1 was terminating the initialisation of the base table, if this is removed to let it continue in to the _txt part, then I can also remove some redundant bytes from the base table as they are already in the second part.
So this will be the better fix - short table = save some bytes in case needed in the future for some other fix :-)
See attachment!
|
@iss000 |
Fixes function 'gr_cls' by adding 'gr_text_w' which on first call was uninitialized.