Patcito/projects enhancements #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as reported in https://drone.gitea.io/go-gitea/gitea/28939/1/4 use log.Error instead of log.Info fix comments fix eslint fix goimport order add migrations for project priorities fix _repository.less lint errors update swagger fixes according to @6543 suggestions s/NotInProjectID/ExcludeProjectID/g update boards priority in a single transaction as per @zeripath Co-authored-by: zeripath <art27@cantab.net> update swagger Clean up the indenting Co-authored-by: zeripath <art27@cantab.net> use tabs Co-authored-by: zeripath <art27@cantab.net> use tabs add loadRepository as per @zeripath suggestion move projects css to features/projects.less as per @silverwind request go-gitea#12506 (review) use transaction to update projects issues priorities as per @zeripath suggestion go-gitea#12506 (comment) make import fit on one line make use of loadRepository indent html properly as per suggestion by @silverwind go-gitea#12506 (comment) remove non-working code as per @zeripath suggestion go-gitea#12506 (comment) remove non-used code as per @zeripath suggestion go-gitea#12506 (comment) fix syntax, remove content-type on request go-gitea#12506 (comment) use closest instead of parent as per @silverwind suggestion go-gitea#12506 (review) use for instead of forEach because @silverwind use for instead of forEach because @silverwind go-gitea#12506 (review) use // falls through as per @silverwind go-gitea#12506 (comment) listen to body keyup only on project page go-gitea#12506 (review) Update models/project_board.go Co-authored-by: Lauris BH <lauris@nix.lv> move all issue related code to its own util file and re-use those functions in index.js and projects.js as per @silverwind and @zeripath Update models/project_issue.go Co-authored-by: 6543 <6543@obermui.de> fix linting Update web_src/js/features/issuesutil.js Co-authored-by: silverwind <me@silverwind.io> Update web_src/js/features/issuesutil.js Co-authored-by: silverwind <me@silverwind.io> Update web_src/js/features/issuesutil.js Co-authored-by: silverwind <me@silverwind.io> Update web_src/js/features/projects.js Co-authored-by: silverwind <me@silverwind.io> Update web_src/js/features/projects.js Co-authored-by: silverwind <me@silverwind.io> Update models/project_issue.go Update models/issue.go Co-authored-by: zeripath <art27@cantab.net> Update web_src/js/features/issuesutil.js Co-authored-by: silverwind <me@silverwind.io> various js fix per @silverwind suggestions various fixes according to @silverwind and @zeripath use await for fetch when possible specify table name as per @lafriks suggestion specify table name as per @lafriks suggestion in more queries go-gitea#12506 (review) go-gitea#12506 (comment) Update templates/repo/projects/view.tmpl Co-authored-by: silverwind <me@silverwind.io> Update templates/repo/projects/view.tmpl Co-authored-by: silverwind <me@silverwind.io> Update web_src/js/features/projects.js Co-authored-by: silverwind <me@silverwind.io> fix project_issue table name in query make another fetch async as per @silverwind Update models/project.go Co-authored-by: Lauris BH <lauris@nix.lv> Update models/project.go Co-authored-by: Lauris BH <lauris@nix.lv> more and rename UpdateBoards functions as per @6543 Update models/project.go Co-authored-by: Lauris BH <lauris@nix.lv> Update models/project.go Co-authored-by: Lauris BH <lauris@nix.lv> add / to route fixup! fix backend lint as reported in https://drone.gitea.io/go-gitea/gitea/28939/1/4 Update models/project.go Co-authored-by: zeripath <art27@cantab.net> Update routers/repo/issue.go Co-authored-by: zeripath <art27@cantab.net> Update web_src/less/features/projects.less Co-authored-by: silverwind <me@silverwind.io> fix uneeded column in query and remove css class as suggested by @silverwind Update models/project.go Co-authored-by: Lauris BH <lauris@nix.lv> add X to close sidebar and other css suggestions by @silverwind add emoji to project issue titles use issue.* instead as suggested by @zeripath still waiting for xorm v1.0.5 to update go.mod fix project_issue query for now fix card details css
6543
pushed a commit
that referenced
this pull request
Apr 8, 2024
Result of `go get -u golang.org/x/net; make tidy`. This is related to the following vulncheck warning: ``` There are 2 vulnerabilities in modules that you require that are neither imported nor called. You may not need to take any action. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck for details. Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/net@v0.22.0 Fixed in: golang.org/x/net@v0.23.0 Vulnerability #2: GO-2022-0470 No access control in github.com/blevesearch/bleve and bleve/v2 More info: https://pkg.go.dev/vuln/GO-2022-0470 Module: github.com/blevesearch/bleve/v2 Found in: github.com/blevesearch/bleve/v2@v2.3.10 Fixed in: N/A ```
6543
pushed a commit
that referenced
this pull request
Apr 9, 2024
Backport go-gitea#30283 by @silverwind Result of `go get -u golang.org/x/net; make tidy`. This is related to the following vulncheck warning: ``` There are 2 vulnerabilities in modules that you require that are neither imported nor called. You may not need to take any action. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck for details. Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/net@v0.22.0 Fixed in: golang.org/x/net@v0.23.0 Vulnerability #2: GO-2022-0470 No access control in github.com/blevesearch/bleve and bleve/v2 More info: https://pkg.go.dev/vuln/GO-2022-0470 Module: github.com/blevesearch/bleve/v2 Found in: github.com/blevesearch/bleve/v2@v2.3.10 Fixed in: N/A ``` Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just save commits of
https://github.com/go-gitea/gitea/pull/12506