Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean all potentially panicking unwraps #3

Closed
OtaK opened this issue Jul 14, 2018 · 0 comments
Closed

Clean all potentially panicking unwraps #3

OtaK opened this issue Jul 14, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
0.6.0

Comments

@OtaK
Copy link
Contributor

OtaK commented Jul 14, 2018

In the codebase, there are 66 occurences of unwrap(), including most of them panicking if there's a problem with SSL/Requests.

Cleaning up will take place in 0.6.0 since it might break the API a bit (eg: returning Result<T, E> instead of T)
@OtaK OtaK added enhancement New feature or request help wanted Extra attention is needed labels Jul 14, 2018
@OtaK OtaK added this to the 0.6.0 milestone Jul 14, 2018
@travismiller travismiller mentioned this issue Aug 21, 2018
Merged
@OtaK OtaK closed this as completed Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@OtaK