Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wallet loading in review-kredits script #67

Merged
merged 1 commit into from Mar 30, 2021
Merged

Fix wallet loading in review-kredits script #67

merged 1 commit into from Mar 30, 2021

Conversation

galfert
Copy link
Contributor

@galfert galfert commented Mar 30, 2021 •
edited

Requiring the wallet JSON file parses it, so we have to read it directly from the filesystem instead.

@galfert
Fix wallet loading in review-kredits script
2e840bc 
Requiring the wallet JSON file parses it, so we have to read it directly
from the filesystem instead.
@galfert galfert added the bug label Mar 30, 2021
@galfert galfert requested a review from gregkare March 30, 2021 11:54
gregkare
gregkare approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@gregkare gregkare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gregkare gregkare merged commit 7db7a83 into master Mar 30, 2021
@gregkare gregkare deleted the bugfix/fix_wallet_loading branch March 30, 2021 12:06
gregkare added a commit to 67P/hal8000 that referenced this pull request Mar 30, 2021
@gregkare
Bump the hubot-kredits commit hash
03dedbb 
Includes 67P/hubot-kredits#67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregkare gregkare gregkare approved these changes

Assignees

@bumi bumi

@galfert galfert

@gregkare gregkare

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@galfert @gregkare @bumi