Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use postcss and autoprefixer, remove old bourbon mixins #116

Merged
merged 5 commits into from
May 11, 2017
Merged

Use postcss and autoprefixer, remove old bourbon mixins #116

merged 5 commits into from
May 11, 2017

Conversation

raucao
Copy link
Member

@raucao raucao commented May 8, 2017

This switches some of Bourbon's deprecated mixins to normal syntax, for
which prefixes are added by postcss/autoprefixer instead.

connected to #114
closes #114

raucao added 2 commits May 9, 2017 01:19
@raucao
Update .jshint config
fe57b50
@raucao
Use postcss and autoprefixer, remove old bourbon mixins
901a861 
This switches some of Bourbon's deprecated mixins to normal syntax, for
which prefixes are added by postcss/autoprefixer instead.

closes #114
galfert
galfert reviewed May 9, 2017
View reviewed changes
.jshintrc
@@ -4,7 +4,8 @@
"window",
"-Promise",
"Promise",
"linkifyStr"
"linkifyStr",
"process"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? I don't see process used anywhere in this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My JSHint was complaining in ember-cli-build.js with the existing code.

@galfert
Copy link
Contributor

galfert commented May 9, 2017

I can see network requests for http://localhost:4200/assets/vendor.css that fail with a 404 now.

@raucao
Copy link
Member Author

raucao commented May 9, 2017

Ouch. One would assume the exclude for a specific plugin means it's not run against those files, not that those files are then dismissed from the build entirely. I'll check the options again.

@raucao
[WIP] Use compile instead of filter for postcss
472795c 
According to the ember-cli-postcss docs, this should only run postcss
on hyperchannel.css, but there seems to be a bug, so this doesn't
actually work right now. I'm committing this, so that I can submit the
bug report with a working (or rather failing) example.
@raucao raucao changed the title Use postcss and autoprefixer, remove old bourbon mixins [WIP] Use postcss and autoprefixer, remove old bourbon mixins May 9, 2017
@raucao
Copy link
Member Author

raucao commented May 9, 2017

I tried to switch to compile from filter, which is supposed to do exactly what we need (just compile hyperchannel.css, not vendor.css. But it doesn't work for me. See commit message.

@raucao raucao mentioned this pull request May 9, 2017
Closed
@raucao
Revert "[WIP] Use compile instead of filter for postcss"
d964140 
This reverts commit 472795c.
@raucao
Update postcss addon
1206723 
This includes a bugfix for the `exclude` issue I found and reported.
@raucao raucao changed the title [WIP] Use postcss and autoprefixer, remove old bourbon mixins Use postcss and autoprefixer, remove old bourbon mixins May 11, 2017
@raucao
Copy link
Member Author

raucao commented May 11, 2017

The author of the plugin fixed the issue I had with the filter and exclude and published a new version. I reverted to the previous commit and now it works as intended.

Please squash-merge and use the first commit's message.

@galfert galfert merged commit c8ef2b0 into master May 11, 2017
@galfert galfert deleted the feature/114-css_autoprefixer branch May 11, 2017 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galfert galfert galfert left review comments

Assignees
No one assigned
Labels
kredits-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use CSS autoprefixer
2 participants
@raucao @galfert