Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix util import #124

Merged
merged 1 commit into from May 4, 2019
Merged

Fix util import #124

merged 1 commit into from May 4, 2019

Conversation

bumi
Copy link
Contributor

@bumi bumi commented May 3, 2019

No description provided.

@bumi bumi added the kredits-1 label May 4, 2019
@bumi
Copy link
Contributor Author

bumi commented May 4, 2019

merging as it is currently broken. but this should be a kredits-0 maybe?

@bumi bumi merged commit 37ce2fd into master May 4, 2019
@bumi bumi deleted the bugfix/fix-me-1 branch May 4, 2019 08:41
@raucao
Copy link
Member

raucao commented May 4, 2019

but this should be a kredits-0 maybe?

You did fix it, and you'll have to publish the npm module, too. So I don't see how it's not a valuable small contribution.

@bumi
Copy link
Contributor Author

bumi commented May 4, 2019

it was only broken in master, the latest release is still fine as far as I checked.

@raucao
Copy link
Member

raucao commented May 4, 2019

Well, then a core team member you can still merge without the label, if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants