Merge pull request #160 from 67P/bugfix/remove_redundant_pending_status

Remove redundant pending status from contribution-status helper

app/helpers/contribution-status.js

@@ -25,8 +25,6 @@ export default Helper.extend({
       status.push('pending');
     }
 
-    status.push('pending');
-
     return status.join(' ');
   },
 

tests/unit/helpers/contribution-status-test.js

@@ -0,0 +1,22 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+import Contribution from 'kredits-web/models/contribution';
+
+module('Unit | Helper | contribution-status', function (hooks) {
+  setupTest(hooks);
+
+  test('returns the appropriate status', function (assert) {
+    const contributionStatus = this.owner.factoryFor('helper:contribution-status').create();
+    const kredits = this.owner.lookup('service:kredits');
+
+    kredits.set('currentBlock', 23000);
+
+    const contributionUnconfirmed = Contribution.create({ confirmedAt: 23001, vetoed: false });
+    const contributionConfirmed   = Contribution.create({ confirmedAt: 21000, vetoed: false });
+    const contributionVetoed      = Contribution.create({ confirmedAt: 23001, vetoed: true });
+
+    assert.equal(contributionStatus.compute([contributionUnconfirmed]), 'unconfirmed');
+    assert.equal(contributionStatus.compute([contributionConfirmed]), 'confirmed');
+    assert.equal(contributionStatus.compute([contributionVetoed]), 'vetoed');
+  });
+});