Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant pending status from contribution-status helper #160

Merged
merged 2 commits into from
Nov 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/helpers/contribution-status.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ export default Helper.extend({
status.push('pending');
}

status.push('pending');

return status.join(' ');
},

Expand Down
22 changes: 22 additions & 0 deletions tests/unit/helpers/contribution-status-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
import Contribution from 'kredits-web/models/contribution';

module('Unit | Helper | contribution-status', function (hooks) {
setupTest(hooks);

test('returns the appropriate status', function (assert) {
const contributionStatus = this.owner.factoryFor('helper:contribution-status').create();
const kredits = this.owner.lookup('service:kredits');

kredits.set('currentBlock', 23000);

const contributionUnconfirmed = Contribution.create({ confirmedAt: 23001, vetoed: false });
const contributionConfirmed = Contribution.create({ confirmedAt: 21000, vetoed: false });
const contributionVetoed = Contribution.create({ confirmedAt: 23001, vetoed: true });

assert.equal(contributionStatus.compute([contributionUnconfirmed]), 'unconfirmed');
assert.equal(contributionStatus.compute([contributionConfirmed]), 'confirmed');
assert.equal(contributionStatus.compute([contributionVetoed]), 'vetoed');
});
});
21 changes: 0 additions & 21 deletions tests/unit/helpers/contribution-status.js

This file was deleted.

21 changes: 0 additions & 21 deletions tests/unit/helpers/is-confirmed-contribution.js

This file was deleted.