Upgrade Ember and deps to 3.18/Octane #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glimmer components don't have extra markup around them, so we don't need the component JS files anymore. Also, we can easily ignore the icon templates when linting now.
We're not using proposals at the moment, so it's just in the way.
These need more updates outside of the templates, like e.g. Glimmer components and such.
The wrong property name caused an exception when trying to remove the observer.
|
Haha, now I wonder how it ever NOT caused an exception :) There was a typo in the property name in the function that removes the observer. I guess older Ember versions kept track of existing observers in a different way that didn't fail when trying to remove a non-existent observer. |
|
|
raucao
changed the title
|
@galfert Thanks! So this is ready to review/merge then. |
|
I'm already reviewing it. |
galfert
reviewed
May 11, 2020
galfert
reviewed
May 11, 2020
|
Thanks! (I cannot reproduce the misalignment of the amounts.) |
Looks ok here now, too. I think it was the missing contribution-status class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't upgrade components to be Glimmer components yet. It's already big enough as it is.
@galfert I'm not sure if you saw my chat message, but when you look at the tests you can find one helper failing (due to some kind of observer issues), and that one failure also seems to break the entire run loop of the Ember app when using it normally, thus freezing the app in place when it hits (which is when you look at contribution details). Hence the WIP.
I also removed all code relating to proposals on the way, as we're not using them at all at the moment. Thus, dragging the code along through big upgrades like this one didn't make sense to me. We can always retrieve it from Git whenever we need it again.