Improve data sync #190
Merged
Improve data sync #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just native Promise will do.
Throws a linter warning, now that it's not an RSVP promise anymore.
galfert
approved these changes
Jun 1, 2020
| @@ -2,12 +2,10 @@ import Component from '@ember/component'; | |||
| import { inject as service } from '@ember/service'; | |||
|
|
|||
| export default Component.extend({ | |||
| tagName: '', | |||
There was a problem hiding this comment.
Since Octane, components don't have a tag like div by default anymore. So this is not necessary.
There was a problem hiding this comment.
You mean Glimmer components. But this one hasn't been converted yet.
|
@galfert Thanks! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces ember-concurrency for managing concurrent tasks, as well as task queues, etc.. The new changes improve the fetching of data in several ways:
After merging this one, we should soon improve the dashboard further by not showing all contributions in the list by default, and also asking the user before fetching the entire history. When we have UI for that, we can then also show sync progress somewhere.