Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expense list UI improvements #211

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Expense list UI improvements #211

merged 4 commits into from
Jan 15, 2023

Conversation

raucao
Copy link
Member

@raucao raucao commented Jan 13, 2023 •
edited
Loading

  • Add expense list component and DRY up the code
  • Add tags
  • Localize dates
  • Improve UI, esp. on small screens

Example of normal expense list (in reimbursement list):

Screenshot from 2023-01-13 15-41-38

Example of expense list in the reimbursement form:

Screenshot from 2023-01-13 15-42-25

@raucao raucao mentioned this pull request Jan 14, 2023
Merged
fsmanuel
fsmanuel approved these changes Jan 14, 2023
View reviewed changes
app/components/add-reimbursement/template.hbs Outdated Show resolved Hide resolved
@raucao @fsmanuel
Update app/components/add-reimbursement/template.hbs
7cd023a 
Co-authored-by: Manuel Wiedenmann <manuel@funkensturm.de>
@raucao raucao merged commit bb11e22 into feature/confirmation-eta Jan 15, 2023
@raucao raucao deleted the feature/expense-list branch January 15, 2023 04:35
@bumi
Copy link
Contributor

bumi commented Jan 17, 2023

this is great! 💅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsmanuel fsmanuel fsmanuel approved these changes

Assignees
No one assigned
Labels
kredits-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raucao @bumi @fsmanuel