uslash including fixed eforth variant #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedie
added a commit
that referenced
this pull request
Jul 2, 2014
uslash including fixed eforth variant
|
See now, you have mixed spaces and tabs :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uslash.asm includes now both variants: First the Talbot Systems one, which is from FIG and erroneous! The second one I have created and added into eForth replacing the high level implementation with influence from various sources (several other Forth implementations, 6502, 6800, 68K, ...). Currently the eForth variant is "active" one.
Some test values and their outcome are included to cover all possible (even special) cases.
BTW: I left the clc/sec syntax omitted for sake of compatibility. ;)
Would you merge back the uslash branch into the master?
Johann