Iframes support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg666
force-pushed
the
feature/iframes
branch
from
fa6d654
to
4bac373
Compare
- added new banner type `EmbedBanner` - added new client `embed/client` that will be used in iframes - existing client moved to the `standard/client` - standard client is able to create iframe banner from elements with attribute `data-amp-mode="embed"` - property `client.version` now returning object of type `ClientVersion`
- updated dependencies - migrated the whole package from CommonJS to ESM - fixed dev/prod build and added embed client to the outputs
- improved embed banners handling - responsive breakpoints from external banners can be now manager by JS client after invoking the method `ExternalBanner.delegateResponsiveBehaviour()`
- both clients are now merged into the single module - export `AMPClientFactory` now contains two methods - `create()` and `createEmbed()` - optimized bundle size with `lodash-webpack-plugin`
tg666
force-pushed
the
feature/iframes
branch
from
4bac373
to
d1eb427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.