feat: udtg for checking if something is a blackboard #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 10
Lines ? 74
Branches ? 9
=======================================
Hits ? 74
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isBlackboardis a useful method for blueshell, which wants to know if its private state is properly initialized, to be able to check that not only is there a thing, but that thing is roughly blackboard-y. Keeping code 100% covered but also dry while dealing with non-runtime types leads to the kinda annoying array of method names.is, as a method on Blackboard, allows checking for reference equality without making that reference available for possible accidental modification. This will be useful for tracking "is the last seen event the one I have" in blueshell. An alternative (optionally allow blackboard items to be flagged as "by reference") is possible, since we already do it (by necessity) for functions and errors, but this seems to open a smaller can of worms.