Continued attempts to get new features to build in PR #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 10
Lines ? 80
Branches ? 11
=======================================
Hits ? 80
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
jbcpollak
reviewed
Mar 26, 2019
.circleci/config.yml
Outdated
| @@ -39,7 +34,7 @@ jobs: | |||
| - run: | |||
| name: Set NPM auth token | |||
| command: | | |||
| npm config set //registry.npmjs.org/:_authToken "${NPM_TOKEN}" | |||
| echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc | |||
There was a problem hiding this comment.
I think this is "less right" than the previous version, but I know both should work so it doesn't matter too much. I suspect _authToken is deprecated in npm, but it should still work for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isBlackboard UDTG will allow Blueshell to make sure that its internal state is properly initialized.
The is method allows for reference-equality checks on a blackboard value (getting the value is not sufficient, because values are deep cloned to prevent accidental updates).
This PR was re-created due to build issues, which the re-creation may or may not help solve.