Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/porting dot tree rendering MOVEMENT-813 #101

Merged
merged 13 commits into from
Jun 24, 2019

Conversation

mbittarelli6river
Copy link
Contributor

Jira: https://6river.atlassian.net/browse/MOVEMENT-857

  • back porting the dot tree serialization to the no-events branch
  • fixing bug in Decorator.ts where onRun was called on the child node instead of run

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (feature/no-events@54e5d4b). Click here to learn what that means.
The diff coverage is 87.09%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             feature/no-events     #101   +/-   ##
====================================================
  Coverage                     ?   89.47%           
====================================================
  Files                        ?       23           
  Lines                        ?      342           
  Branches                     ?       42           
====================================================
  Hits                         ?      306           
  Misses                       ?       28           
  Partials                     ?        8
Impacted Files Coverage Δ
lib/nodes/composites/IfElse.ts 82.35% <0%> (ø)
lib/nodes/decorators/ResultSwap.ts 90.9% <0%> (ø)
lib/nodes/composites/Sequence.ts 93.75% <0%> (ø)
lib/nodes/decorators/Not.ts 91.66% <0%> (ø)
lib/nodes/composites/Selector.ts 81.25% <0%> (ø)
lib/nodes/decorators/RepeatWhen.ts 75% <0%> (ø)
lib/nodes/decorators/RepeatOnResult.ts 75% <0%> (ø)
lib/nodes/composites/LatchedSelector.ts 100% <100%> (ø)
lib/nodes/decorators/Decorator.ts 100% <100%> (ø)
lib/utils/renderTree.ts 100% <100%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e5d4b...cf2d9db. Read the comment docs.

@Ccarlson6r Ccarlson6r merged commit 4bd7689 into feature/no-events Jun 24, 2019
@Ccarlson6r Ccarlson6r deleted the feat/porting_dot_tree_rendering branch June 24, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants