Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node 10 matching the mfp app (CUR-1069) #125

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

mgabeler-lee-6rs
Copy link
Contributor

We should build & test this with the same nodejs version under which it is run

@mgabeler-lee-6rs mgabeler-lee-6rs changed the title fix: use node 10 matching the mfp app fix: use node 10 matching the mfp app (CUR-1069) Jul 7, 2021
tonygaetani
tonygaetani previously approved these changes Jul 7, 2021
@6rs-qa-bot
Copy link

6rs-qa-bot bot commented Jul 7, 2021

Tickets found in PR

Deselect all that are not part of this release

The release version will be posted to each check marked ticket once the PR is merged

To add additional tickets, include the ticket key in a comment, the PR title, or a commit

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #125 (9691fba) into main (a9277b9) will increase coverage by 93.27%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main     #125       +/-   ##
=========================================
+ Coverage      0   93.27%   +93.27%     
=========================================
  Files         0       32       +32     
  Lines         0      461      +461     
  Branches      0       75       +75     
=========================================
+ Hits          0      430      +430     
- Misses        0       23       +23     
- Partials      0        8        +8     

Copy link
Member

@tonygaetani tonygaetani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing codecov!

@mgabeler-lee-6rs mgabeler-lee-6rs merged commit 9e5a018 into main Jul 7, 2021
@mgabeler-lee-6rs mgabeler-lee-6rs deleted the fix/node-ten-match-mfp branch July 7, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants