Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug in while return value #144

Merged
merged 6 commits into from
Nov 12, 2021
Merged

fix: bug in while return value #144

merged 6 commits into from
Nov 12, 2021

Conversation

tdeignan1
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #144 (64f5f9c) into main (3467784) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   93.07%   93.12%   +0.05%     
==========================================
  Files          36       36              
  Lines         534      538       +4     
  Branches       84       86       +2     
==========================================
+ Hits          497      501       +4     
  Misses         28       28              
  Partials        9        9              

@tdeignan1 tdeignan1 changed the title fix: While node must return the result of the child if the child runs fix: bug in while return value Nov 12, 2021
Copy link

@asdocoder asdocoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tdeignan1 tdeignan1 merged commit 8136611 into main Nov 12, 2021
@tdeignan1 tdeignan1 deleted the fix/while-result branch November 12, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants