Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render by visitor #95

Merged
merged 15 commits into from
Mar 10, 2019
Merged

Render by visitor #95

merged 15 commits into from
Mar 10, 2019

Conversation

ddurschlag6river
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #95 into master will increase coverage by 1.31%.
The diff coverage is 94.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   91.85%   93.16%   +1.31%     
==========================================
  Files          21       23       +2     
  Lines         270      366      +96     
  Branches       19       27       +8     
==========================================
+ Hits          248      341      +93     
- Misses         21       24       +3     
  Partials        1        1
Impacted Files Coverage Δ
lib/utils/resultCodes.ts 100% <100%> (ø) ⬆️
lib/index.ts 100% <100%> (ø) ⬆️
lib/utils/archyTree.ts 96.87% <100%> (+1.42%) ⬆️
lib/utils/NodeVisitor.ts 100% <100%> (ø)
lib/utils/renderTree.ts 90.47% <84.61%> (-9.53%) ⬇️
lib/utils/d3Hierarchy.ts 88.88% <88.88%> (ø)
lib/utils/dotTree.ts 91.93% <89.79%> (+2.57%) ⬆️
lib/nodes/LatchedSequence.ts 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1c62d...edf096e. Read the comment docs.

) {
super(node);
}
public* visitChildren() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the * do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generator syntax. Directly analogous to C#'s yield return version of IEnumerable properties. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Iterators_and_Generators#Generator_functions for more.

Shockolate
Shockolate previously approved these changes Mar 8, 2019
Copy link
Contributor

@townbully townbully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ddurschlag6river ddurschlag6river merged commit 09de51f into master Mar 10, 2019
@ddurschlag6river ddurschlag6river deleted the renderByVisitor branch March 10, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants