Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new nodes -- Predicate, SideEffect, and Success #97

Merged
merged 2 commits into from Mar 5, 2019

Conversation

ddurschlag6river
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #97 into master will increase coverage by 0.72%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   90.43%   91.16%   +0.72%     
==========================================
  Files          17       20       +3     
  Lines         230      249      +19     
  Branches       17       19       +2     
==========================================
+ Hits          208      227      +19     
  Misses         21       21              
  Partials        1        1
Impacted Files Coverage Δ
lib/index.ts 100% <ø> (ø) ⬆️
lib/nodes/LatchedSequence.ts 75% <0%> (ø) ⬆️
lib/nodes/Predicate.ts 100% <100%> (ø)
lib/nodes/SideEffect.ts 100% <100%> (ø)
lib/nodes/Success.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7da7f...94ff447. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #97 into master will increase coverage by 1.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   90.43%   91.85%   +1.41%     
==========================================
  Files          17       21       +4     
  Lines         230      270      +40     
  Branches       17       19       +2     
==========================================
+ Hits          208      248      +40     
  Misses         21       21              
  Partials        1        1
Impacted Files Coverage Δ
lib/nodes/Predicate.ts 100% <100%> (ø)
lib/index.ts 100% <100%> (ø) ⬆️
lib/nodes/SideEffect.ts 100% <100%> (ø)
lib/nodes/Success.ts 100% <100%> (ø)
lib/nodes/decorators/index.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7da7f...7b11312. Read the comment docs.

jbcpollak
jbcpollak previously approved these changes Mar 4, 2019
Copy link
Contributor

@jbcpollak jbcpollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you being so explicit about the test states? It should work with just an empty object?


export class Success<S extends BlueshellState, E> extends Base<S, E> {
constructor(
name = `Success`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there backticks here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/pasta from a version that injected a resultcode and actually put it in the name.

@ddurschlag6river ddurschlag6river merged commit ca1c62d into master Mar 5, 2019
@ddurschlag6river ddurschlag6river deleted the feat/new-nodes branch March 5, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants