New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new nodes -- Predicate, SideEffect, and Success #97
Conversation
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 90.43% 91.16% +0.72%
==========================================
Files 17 20 +3
Lines 230 249 +19
Branches 17 19 +2
==========================================
+ Hits 208 227 +19
Misses 21 21
Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 90.43% 91.85% +1.41%
==========================================
Files 17 21 +4
Lines 230 270 +40
Branches 17 19 +2
==========================================
+ Hits 208 248 +40
Misses 21 21
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you being so explicit about the test states? It should work with just an empty object?
lib/nodes/Success.ts
Outdated
|
||
export class Success<S extends BlueshellState, E> extends Base<S, E> { | ||
constructor( | ||
name = `Success` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there backticks here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/pasta from a version that injected a resultcode and actually put it in the name.
No description provided.