fix(picker): column exclude from ColumnPicker, GridMenu caussing issue #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- found by looking into Cypress E2E tests, ref PR #399 - because there is a grid setColumns, we cannot just remove the excluded columns, if we do it causes some issues when showing/hiding columns later. - what is better is to simply keep excluded item in the list but simply hide the checkbox from the picker list.
|
Is this working for anyone, not working for me. Please reply if have any other solution to always enable checkbox column after show/hide column also. Thanks in advanced. |
|
This PR was to exclude columns from the picker, what you're describing seems different than that. I don't exactly understand your question, but if you mean to have a column always shown that the user cannot unclick, that is not currently doable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setColumns, we cannot just remove the excluded columns, if we do it causes some issues when clicking checkbox to show/hide columns later. It removes the excluded column completely from the grid as soon as we click on the checkbox of any item, that is because we call thesetColumnswithout the excluded item.From the animated gif below, you can see the 2 first columns ("#" and "A") hides when clicking only item "A"
