fix: unsubscribe everything event & nullify DOM elements avoid detach elements #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- see this Stack Overflow [question](https://stackoverflow.com/questions/16901759/javascript-memory-leaks-detached-dom-tree) for reference
ghiscoding
changed the title
|
Howdy Ben? Hope you're doing good down there. If you have a chance to review this PR, I'm done with it, it's fixing a few unsubscribe events and possible detached DOM elements. If you could do another release after merging the PR, that would be great too. Thanks again mate 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a bunch of detached DOM elements when used in SPA (Single Page App) like in Angular-Slickgrid, going in and out on about 20 pages, I get about a thousand detached div/span elements and this PR helps a lot in fixing that issue.