feat: add item count to data change handlers #570

ghiscoding · 2021-01-20T15:14:18Z

add item count to onRowCountChanged
add item count to onRowsChanged
add item count to onRowsOrCountChanged
add item count to onSetItemsCalled
also renamed getItemsCount to singular getItemCount so that it's aligned with the other counter.
- note: this was a new function to get merged just 2 days ago, so it's ok to rename it now
onSetItemsCalled event should be called before the refresh method since that can itself trigger onRowCountChanged but it has to be after the onSetItemsCalled event instead of before

- add item count to `onRowCountChanged` - add item count to `onRowsOrCountChanged` - add item count to `onSetItemsCalled`

- the onSetItemsCalled should be called first and then the refresh can itself trigger onRowCountChanged but it has to be after the onSetItemsCalled event

ghiscoding added 3 commits January 20, 2021 10:13

feat: add item count to data change handlers

16c3b01

- add item count to `onRowCountChanged` - add item count to `onRowsOrCountChanged` - add item count to `onSetItemsCalled`

refactor: renamed getItemsCount to singular getItemCount

6089e47

refactor: onSetItemsCalled event should be called before refresh

4f7b544

- the onSetItemsCalled should be called first and then the refresh can itself trigger onRowCountChanged but it has to be after the onSetItemsCalled event

ghiscoding merged commit 32e03d5 into master Jan 22, 2021

ghiscoding deleted the feat/handler-item-count branch January 22, 2021 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add item count to data change handlers #570

feat: add item count to data change handlers #570

ghiscoding commented Jan 20, 2021 •

edited

feat: add item count to data change handlers #570

feat: add item count to data change handlers #570

Conversation

ghiscoding commented Jan 20, 2021 • edited

ghiscoding commented Jan 20, 2021 •

edited