Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Migration of SlickGrid to TypeScript #575

Closed
Danielku15 opened this issue Feb 11, 2021 · 3 comments
Closed

Discussion: Migration of SlickGrid to TypeScript #575

Danielku15 opened this issue Feb 11, 2021 · 3 comments

Comments

@Danielku15
Copy link
Contributor

I am following up here the discussion of #572, I think it is worth having an own dedicated issue for that 😉 @6pac @ghiscoding

It would be worth a consideration to migration SlickGrid to a typescript codebase and try to modernize the codebase by eliminating some dependencies of which some are maybe even unmaintained.

Some benefits on that:

  • A more modern tech-stack attracts more developers to contribute. Getting new devs bootstrapped and accomodated with the SlickGrid development environment is eaiser this way.
  • Providing libraries for other projects becomes easier (NPM, TypeScript definitions,..)
  • Dependency management gets more visible
  • Removing jQuery makes it more attractive for new frameworks like Angular, React etc. which usually avoid jQuery.
  • Test infrastructure, documentation etc. is easier to maintain.
  • Code quality overall can be improved (TSDoc, TypeSafety, OOP development style, module system compatibility,..)

If there is a strategy in this regards, I could try to prepare a basic infrastructure based on my own project which provides bundling, CI/CD scripts, etc. Or you just peek into my structure as a first idea:

It might have a bit more than SlickGrid will need. But especially setting up rollup, typescript, karma, incremental compilation etc. took me a bit, but now it's really smooth (to me at least 😁 ).

@Danielku15 Danielku15 changed the title Discussion: Migration of SlickGrid to TypeScript. Discussion: Migration of SlickGrid to TypeScript Feb 11, 2021
@ghiscoding
Copy link
Collaborator

ghiscoding commented Feb 11, 2021

@6pac
Can you open the GitHub "Discussion" tab in your project, I think it would be better use for this

@ghiscoding
Copy link
Collaborator

@Danielku15 the Discussion tab is now open, can you move your text in a new Discussion.. oh wait there's a button "Convert to discussion", please do that

image

@Danielku15
Copy link
Contributor Author

@ghiscoding Only Repository Maintainers can do that 😉 Feel free to move it.
image

Repository owner locked and limited conversation to collaborators Feb 11, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants