Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add preventDefault to optionally leave plugin menu open #589

Merged
merged 1 commit into from Mar 21, 2021
Merged

fix: add preventDefault to optionally leave plugin menu open #589

merged 1 commit into from Mar 21, 2021

Conversation

ghiscoding
Copy link
Collaborator

  • fixes Minor change for handleMenuItemClick #582
  • the original issue only mentioned the HeaderMenu plugin but I went ahead and applied the same logic (and tested them all) on the following plugins
    • HeaderMenu
    • GridMenu
    • ContextMenu
    • CellMenu

@ghiscoding
fix: add preventDefault to optionally leave plugin menu open
a7ffc4e 
- fixes #582
- the original issue only mentioned the HeaderMenu plugin but I went ahead and applied the same logic (and tested them all) on the following plugins
   - HeaderMenu
   - GridMenu
   - ContextMenu
   - CellMenu
@6pac 6pac merged commit c7dfe45 into master Mar 21, 2021
@ghiscoding ghiscoding deleted the feat/plugin-menu-prevent-default branch August 12, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor change for handleMenuItemClick
2 participants
@ghiscoding @6pac