Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deactivate edit controller shouldn't throw when active is null #604

Merged
merged 1 commit into from May 6, 2021

Conversation

ghiscoding
Copy link
Collaborator

it had errors thrown when using autoEdit and setActiveCell which calls makeActiveCellNormal which calls deactivate which finally throws that error even when the active edit controller is null but that shouldn't matter if it is already null then we shouldn't care and not throw

@6pac 6pac merged commit 28f44a3 into master May 6, 2021
@ghiscoding
Copy link
Collaborator Author

@6pac I'm not planning any other code change and this error thrown is blocking me from releasing a new version in my libs, so if you could release a new version in coming days that would be awesome. Thanks mate

@ghiscoding ghiscoding deleted the bugfix/edit-controller-deactivate branch August 12, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants