Fix #20, clear the view reference in AbstractPresenter#onViewDetached

6thsolution · Jan 11, 2017 · 5555437 · 5555437
1 parent 7c202c0
commit 5555437
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 0 deletions.
diff --git a/easymvp-api/src/main/java/easymvp/AbstractPresenter.java b/easymvp-api/src/main/java/easymvp/AbstractPresenter.java
@@ -21,6 +21,7 @@ public void onViewAttached(V view) {
 
     @Override
     public void onViewDetached() {
+        this.view.clear();
     }
 
     @Override

diff --git a/easymvp-test/src/main/java/com/sixthsolution/easymvp/test/SimpleAppCompatActivity.java b/easymvp-test/src/main/java/com/sixthsolution/easymvp/test/SimpleAppCompatActivity.java
@@ -10,6 +10,7 @@
 import easymvp.annotation.ActivityView;
 import easymvp.annotation.Presenter;
 
+import static junit.framework.Assert.assertFalse;
 import static junit.framework.Assert.assertNotNull;
 import static junit.framework.Assert.assertNull;
 import static junit.framework.Assert.assertTrue;
@@ -41,6 +42,7 @@ protected void onStart() {
     protected void onStop() {
         super.onStop();
         assertTrue(testPresenter.isOnViewDetachedCalled());
+        assertFalse(testPresenter.isViewAttached());
     }
 
     @Override

diff --git a/...t/src/main/java/com/sixthsolution/easymvp/test/SimpleAppCompatActivityWithCustomView.java b/...t/src/main/java/com/sixthsolution/easymvp/test/SimpleAppCompatActivityWithCustomView.java
@@ -7,6 +7,7 @@
 import easymvp.annotation.ActivityView;
 import easymvp.annotation.Presenter;
 
+import static junit.framework.Assert.assertFalse;
 import static junit.framework.Assert.assertNotNull;
 import static junit.framework.Assert.assertNull;
 import static junit.framework.Assert.assertTrue;
@@ -38,6 +39,7 @@ protected void onStart() {
     protected void onStop() {
         super.onStop();
         assertTrue(testPresenter.isOnViewDetachedCalled());
+        assertFalse(testPresenter.isViewAttached());
     }
 
     @Override

diff --git a/...est/src/main/java/com/sixthsolution/easymvp/test/SimpleAppCompatActivityWithFragment.java b/...est/src/main/java/com/sixthsolution/easymvp/test/SimpleAppCompatActivityWithFragment.java
@@ -7,6 +7,7 @@
 import easymvp.annotation.ActivityView;
 import easymvp.annotation.Presenter;
 
+import static junit.framework.Assert.assertFalse;
 import static junit.framework.Assert.assertNotNull;
 import static junit.framework.Assert.assertNull;
 import static junit.framework.Assert.assertTrue;
@@ -37,6 +38,7 @@ protected void onStart() {
     protected void onStop() {
         super.onStop();
         assertTrue(testPresenter.isOnViewDetachedCalled());
+        assertFalse(testPresenter.isViewAttached());
     }
 
     @Override

diff --git a/easymvp-test/src/main/java/com/sixthsolution/easymvp/test/SimpleFragment.java b/easymvp-test/src/main/java/com/sixthsolution/easymvp/test/SimpleFragment.java
@@ -10,6 +10,7 @@
 import easymvp.annotation.FragmentView;
 import easymvp.annotation.Presenter;
 
+import static junit.framework.Assert.assertFalse;
 import static junit.framework.Assert.assertNotNull;
 import static junit.framework.Assert.assertNull;
 import static junit.framework.Assert.assertTrue;
@@ -41,6 +42,7 @@ public void onResume() {
     public void onPause() {
         super.onPause();
         assertTrue(testPresenter.isOnViewDetachedCalled());
+        assertFalse(testPresenter.isViewAttached());
     }
 
     @Override