Cursor moves out of visible window area

[andycraig]

Thank you very much for making this and putting it on the marketplace!

I've found that when in normal mode, moving the cursor off the top or bottom of the window does not cause the window to scroll.

To reproduce:

1. Have enough text in the file that the bottom of the file cannot be seen
2. Be in normal mode (not insert mode)
3. Keep pressing j until the cursor moves below the last visible line
4. Observe that the window does not scroll, and the cursor is no longer visible

The same applies when the top of the file is not visible and I move the cursor to the start of the file using gg.

I've disabled all extensions except Dance.

I've observed the issue on Linux and Windows.

Version info (Linux):

Dance: 0.1.4
Ubuntu 18.04.2 LTS
VSCode:
Version: 1.39.2
Commit: 6ab598523be7a800d7f3eb4d92d7ab9a66069390
Date: 2019-10-15T15:33:40.634Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-70-generic

Thank you, and let me know if there's any other info I can provide etc.!

[timjs]

Heaving the same issue here.

[71]

I just realized that the whole move implementation (left, right, top, down) is broken in various other ways... I've started working on a fix but it's going to take some time. In any case, thanks for the report.

[andycraig]

No problems, I look forward to the fix whenever it’s ready :) Thanks again for all your work on this!

[71]

Commit bb84bfd fixes movements to be the same as Kakoune's!

[andycraig]

Wow, that was a lot quicker than I expected! Thank you!

[timjs]

This still happens when using goto commands like gg or ge, when using the new n or a+n searches or just using search itself / or a+/!