Fix check for GUI apps and don't wait for GUI apps to complete #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't wait for GUI apps to complete Don't need to combine shim app name with command line parameters Resharper cleanup Added makefile as example for building Building with /MD option (msvcrt.dll) makes for much smaller shim.exe (12 KB vs 113 KB)
|
Hey there, and thanks for the fix! I haven't really had time to review it, especially since the file is very different now (and uses a different code style), but still have this task on my todo list. |
If you approve of the gist of these changes, I can rework it to be less different if you prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some code refactoring and cleanup along with fixing the check for GUI apps and not waiting for GUI apps to complete. I also made the shim reader more flexible by making the spaces around the equal signs optional and not requiring a final linefeed character.