Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort sub-directories alphabetically #47

Merged
merged 1 commit into from Jul 18, 2019

Conversation

alfie-max
Copy link
Contributor

No description provided.

@@ -21,7 +21,7 @@ def basename
end

def children
directory.children.map do |child|
directory.children.sort.map do |child|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure which attribute will get used for sorting. @alfie-max Can you give more details?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetically based on the directory names would be my first thought

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work on

def sort_order
method instead. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the file parser.

i get that we can specify the sort order for each .json file
But what I'm talking is about the sort order of subdirectories

Here's my directory structure..
screenshot 2018-12-27 at 11 25 03 pm

So with this PR, i'm aiming to alphabetically sort authentication companies products

By default products comes first where as i'd expect authetication would have

@alfie-max
Copy link
Contributor Author

@alameenkhader looked into this today and figured out a better implementation for it.. Check it out.. i think it's a better way of achieving a proper sorting of directories..

@alameenkhader alameenkhader added this to the release v1.5.4 milestone Jul 18, 2019
@alameenkhader alameenkhader merged commit f696131 into 72pulses:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants