Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendments for test and cover commands #39

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Amendments for test and cover commands #39

merged 1 commit into from
Oct 14, 2018

Conversation

rheber
Copy link
Contributor

@rheber rheber commented Oct 14, 2018

Add nyc as a dev dependency.
Modify test and cover commands to use glob-run so that
glob expansion works on Windows.
Add .coveralls.yml to .gitignore.

Add nyc as a dev dependency.
Modify test and cover commands to use glob-run so that
glob expansion works on Windows.
Add .coveralls.yml to .gitignore.
@75lb 75lb merged commit d324459 into 75lb:master Oct 14, 2018
@75lb
Copy link
Owner

75lb commented Oct 14, 2018

thanks 👍

@75lb
Copy link
Owner

75lb commented Oct 14, 2018

I fixed the bug in test-runner which was preventing it expanding glob patterns on Windows, therefore glob-run is no longer needed here - it is now removed on the master branch. Please update your local branch.

Also, please update your npm to the latest version as the package-lock you pushed contained entirely fixed semver paths (i.e. the ^ was missing) which is an old bug - you need to update npm.

@rheber rheber deleted the cover branch October 16, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants