Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

更新babel依赖 #525

Merged
merged 1 commit into from
Dec 15, 2016
Merged

更新babel依赖 #525

merged 1 commit into from
Dec 15, 2016

Conversation

snadn
Copy link
Contributor

@snadn snadn commented Dec 14, 2016

  1. 去掉es2015-loose 的依赖。因为已Deprecation。 https://github.com/bkonkle/babel-preset-es2015-loose
  2. 修改 watch_compile 中 babel 配置默认 presets,plugins 为空。因为配置已经移到 .babelrc , 同时方便完全定制配置选项。

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.633% when pulling b7d21be on snadn:update-babel into 0a72167 on 75team:master.

@welefen
Copy link
Member

welefen commented Dec 14, 2016

哦,你这个还是用 babel-preset-es2015,那就是没啥问题

@snadn
Copy link
Contributor Author

snadn commented Dec 14, 2016

之所以要改,是因为用loose编 react的view的时候,出错了,然后去loose的项目里面发现已经废弃。改用es2015加参数,ok。

@welefen
Copy link
Member

welefen commented Dec 14, 2016

文件修改 src/util/watch_compile.js 里的 es2015-loose 也要改成 es2015 的方式

@snadn
Copy link
Contributor Author

snadn commented Dec 15, 2016

src/util/watch_compile.js 里面之所以那么改,是为了考虑兼容。万一有用户更新了thinkjs,但项目里面的其他依赖又没改,thinkjs的模板也没更新,那样就会被坑。然而,如果是全新使用的话,用户是不会受那个es2015-loose影响的。当然,也可以考虑加入warning来提示用户更新。

@welefen welefen merged commit 6f4f53a into thinkjs:master Dec 15, 2016
@snadn snadn deleted the update-babel branch May 2, 2018 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants