Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

each path as new Object3D #3

Merged
merged 2 commits into from
Jun 6, 2017
Merged

each path as new Object3D #3

merged 2 commits into from
Jun 6, 2017

Conversation

morandd
Copy link
Contributor

@morandd morandd commented Jun 6, 2017

In the original implementation all SVG paths are aggregated together into a single string.

In my case this resulted in problems when polygons overlap, for example in this text image:
overlaptest.svg.txt

Overlapping paths create holes in the mesh. This is some issue in svg-mesh-3d.
hole

I've filed this as a bug: mattdesl/svg-mesh-3d#6

This branch avoids the issue by iterating over each item in the SVG and adding each individually so the element's object3d group.

I also:

  • added width and height parameters to rescale into AFrame space
  • added warnings if the SVG contains or other currently unsupported tags,
  • added tips in the README.

thanks for your work on this valuable AFrame component

@7dir 7dir merged commit 0193d4a into 7dir:master Jun 6, 2017
@7dir
Copy link
Owner

7dir commented Jun 6, 2017

Can U add Width or Height demo?
#5

@7dir
Copy link
Owner

7dir commented Jun 6, 2017

debug demo?
#6

@7dir
Copy link
Owner

7dir commented Jun 6, 2017

add demo with warnings if the SVG contains or other currently unsupported tags
#7

@7dir
Copy link
Owner

7dir commented Jun 6, 2017

@morandd ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants